Skip to content

support sorting multi-file diff before printing #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sqs
Copy link
Member

@sqs sqs commented Mar 24, 2019

NOTE: This is just a demo PR. It is not intended to be merged.

Makes it easier to canonicalize the output of PrintMultiFileDiff by adding a new PrintOptions arg that lets the caller specify that the diffs should be sorted before printing.

@sqs sqs self-assigned this Mar 24, 2019
@sqs sqs force-pushed the github-import-path branch 2 times, most recently from eda26d8 to de643bf Compare March 24, 2019 18:23
@sqs sqs changed the base branch from github-import-path to master March 24, 2019 18:26
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #31 into master will decrease coverage by 0.09%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #31     +/-   ##
=========================================
- Coverage   26.91%   26.82%   -0.1%     
=========================================
  Files           5        5             
  Lines        1133     1137      +4     
=========================================
  Hits          305      305             
- Misses        784      787      +3     
- Partials       44       45      +1
Impacted Files Coverage Δ
diff/print.go 42.5% <20%> (-2.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042635e...459b936. Read the comment docs.

Makes it easier to canonicalize the output of `PrintMultiFileDiff` by adding a new `PrintOptions` arg that lets the caller specify that the diffs should be sorted before printing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant